• Tom Lane's avatar
    Teach psql's tab completion to consider the entire input string. · d854118c
    Tom Lane authored
    Up to now, the tab completion logic has only examined the last few words
    of the current input line; "last few" being originally as few as four
    words, but lately up to nine words.  Furthermore, it only looked at what
    libreadline considers the current line of input, which made it rather
    myopic if you split your command across lines.  This was tolerable,
    sort of, so long as the match patterns were only designed to consider the
    last few words of input; but with the recent addition of HeadMatches()
    and Matches() matching rules, we really have to do better if we want
    those to behave sanely.
    
    Hence, change the code to break the entire line down into words, and to
    include any previous lines in the command buffer along with the active
    readline input buffer.
    
    This will be a little bit slower than the previous coding, but some
    measurements say that even a query of several thousand characters can be
    parsed in a hundred or so microseconds on modern machines; so it's really
    not going to be significant for interactive tab completion.  To reduce
    the cost some, I arranged to avoid the per-word malloc calls that used
    to occur: all the words are now kept in one malloc'd buffer.
    d854118c
mainloop.c 12.1 KB