• Tom Lane's avatar
    Fix a couple of contrib/dblink bugs. · d843ed21
    Tom Lane authored
    dblink_exec leaked temporary database connections if any error occurred
    after connection setup, for example
    	SELECT dblink_exec('...connect string...', 'select 1/0');
    Add a PG_TRY block to ensure PQfinish gets done when it is needed.
    (dblink_record_internal is on the hairy edge of needing similar treatment,
    but seems not to be actively broken at the moment.)
    
    Also, in 9.0 and up, only one of the three functions using tuplestore
    return mode was properly checking that the query context would allow
    a tuplestore result.
    
    Noted while reviewing dblink patch.  Back-patch to all supported branches.
    d843ed21
dblink.c 58.1 KB