• Tom Lane's avatar
    Reorder code in pg_dump to dump comments etc in a uniform order. · d6c84667
    Tom Lane authored
    Most of the code in pg_dump dumps an object's comment, security label,
    and ACL auxiliary TOC entries, in that order, immediately after the
    object's main TOC entry, and at least dumpComment's API spec says this
    isn't optional.  dumpDatabase was significantly violating that when
    in binary-upgrade mode, by inserting totally unrelated stuff between.
    Also, dumpForeignDataWrapper and dumpForeignServer were being randomly
    inconsistent.  Reorder code so everybody does it the same.
    
    This may be future-proofing us against some code growing a requirement for
    such auxiliary entries to be adjacent to their main entry.  But for now
    it's just neatnik-ism, so I see no need for back-patch.
    
    Discussion: https://postgr.es/m/21714.1516553459@sss.pgh.pa.us
    d6c84667
pg_dump.c 544 KB