• Alvaro Herrera's avatar
    Fix thinko in lock mode enum · d5e3d1e9
    Alvaro Herrera authored
    Commit 0e5680f4 contained a thinko
    mixing LOCKMODE with LockTupleMode.  This caused misbehavior in the case
    where a tuple is marked with a multixact with at most a FOR SHARE lock,
    and another transaction tries to acquire a FOR NO KEY EXCLUSIVE lock;
    this case should block but doesn't.
    
    Include a new isolation tester spec file to explicitely try all the
    tuple lock combinations; without the fix it shows the problem:
    
        starting permutation: s1_begin s1_lcksvpt s1_tuplock2 s2_tuplock3 s1_commit
        step s1_begin: BEGIN;
        step s1_lcksvpt: SELECT * FROM multixact_conflict FOR KEY SHARE; SAVEPOINT foo;
        a
    
        1
        step s1_tuplock2: SELECT * FROM multixact_conflict FOR SHARE;
        a
    
        1
        step s2_tuplock3: SELECT * FROM multixact_conflict FOR NO KEY UPDATE;
        a
    
        1
        step s1_commit: COMMIT;
    
    With the fixed code, step s2_tuplock3 blocks until session 1 commits,
    which is the correct behavior.
    
    All other cases behave correctly.
    
    Backpatch to 9.3, like the commit that introduced the problem.
    d5e3d1e9
heapam.c 239 KB