• Tom Lane's avatar
    Adopt a more compact, less error-prone notation for tab completion code. · d37b816d
    Tom Lane authored
    Replace tests like
    
        else if (pg_strcasecmp(prev4_wd, "CREATE") == 0 &&
                 pg_strcasecmp(prev3_wd, "TRIGGER") == 0 &&
                 (pg_strcasecmp(prev_wd, "BEFORE") == 0 ||
                  pg_strcasecmp(prev_wd, "AFTER") == 0))
    
    with new notation like this:
    
        else if (TailMatches4("CREATE", "TRIGGER", MatchAny, "BEFORE|AFTER"))
    
    In addition, provide some macros COMPLETE_WITH_LISTn() to reduce the amount
    of clutter needed to specify a small number of predetermined completion
    alternatives.
    
    This makes the code substantially more compact: tab-complete.c gets over a
    thousand lines shorter in this patch, despite the addition of a couple of
    hundred lines of infrastructure for the new notations.  The new way of
    specifying match rules seems a whole lot more readable and less
    error-prone, too.
    
    There's a lot more that could be done now to make matching faster and more
    reliable; for example I suspect that most of the TailMatches() rules should
    now be Matches() rules.  That would allow them to be skipped after a single
    integer comparison if there aren't the right number of words on the line,
    and it would reduce the risk of unintended matches.  But for now, (mostly)
    refrain from reworking any match rules in favor of just converting what
    we've got into the new notation.
    
    Thomas Munro, reviewed by Michael Paquier, some adjustments by me
    d37b816d
tab-complete.c 129 KB