• Andres Freund's avatar
    Fix two off-by-one errors in bufmgr.c. · d25fbf9f
    Andres Freund authored
    In 4b4b680c I passed a buffer index number (starting from 0) instead of
    a proper Buffer id (which start from 1 for shared buffers) in two
    places.
    
    This wasn't noticed so far as one of those locations isn't compiled at
    all (PrintPinnedBufs) and the other one (InvalidBuffer) requires a
    unlikely, but possible, set of circumstances to trigger a symptom.
    
    To reduce the likelihood of such incidents a bit also convert existing
    open coded mappings from buffer descriptors to buffer ids with
    BufferDescriptorGetBuffer().
    
    Author: Qingqing Zhou
    Reported-By: Qingqing Zhou
    Discussion: CAJjS0u2ai9ooUisKtkV8cuVUtEkMTsbK8c7juNAjv8K11zeCQg@mail.gmail.com
    Backpatch: 9.5 where the private ref count infrastructure was introduced
    d25fbf9f
bufmgr.c 105 KB