• Tom Lane's avatar
    Fix incorrect buffer-length argument to uloc_getDisplayName(). · d1fcc622
    Tom Lane authored
    The maxResultSize argument of uloc_getDisplayName is the number of
    UChars in the output buffer, not the number of bytes.  In principle
    this could result in a stack smash, although at least in my Fedora 25
    install there are no ICU locales with display names long enough to
    overrun the buffer.  But it's easily proven to be wrong by reducing
    the length of displayname to around 20, whereupon a stack smash
    does happen.
    
    (This is a rather scary bug, because the same mistake could easily
    have been made in other places; but in a quick code search looking
    at uses of UChar I could not find any other instances.)
    d1fcc622
collationcmds.c 19.8 KB