• Tom Lane's avatar
    Fix bootstrap parser so that its keywords are unreserved words. · d160882a
    Tom Lane authored
    Mark Dilger pointed out that the bootstrap parser does not allow
    any of its keywords to appear as column values unless they're quoted,
    and proposed dealing with that by quoting such values in genbki.pl.
    Looking closer, though, we also have that problem with respect to table,
    column, and type names appearing in the .bki file: the parser would fail
    if any of those matched any of its keywords.  While so far there have
    been no conflicts (that I've heard of), this seems like a booby trap
    waiting to catch somebody.  Rather than clutter genbki.pl with enough
    quoting logic to handle all that, let's make the bootstrap parser grow
    up a little bit and treat its keywords as unreserved.
    
    Experimentation shows that it's fairly easy to do so with the exception
    of _null_, which I don't have a big problem with keeping as a reserved
    word.  The only change needed is that we can't have the "close" command
    take an optional table name: it has to either require or forbid the
    table name to avoid shift/reduce conflicts.  genbki.pl has historically
    always included the table name, so I took that option.
    
    The implementation has bootscanner.l passing forward the string value
    of each keyword, in case bootparse.y needs that.  This avoids needing to
    know the precise spelling of each keyword in bootparse.y, which is good
    because that's not always obvious from the token name.
    
    Discussion: https://postgr.es/m/3024FC91-DB6D-4732-B31C-DF772DF039A0@gmail.com
    d160882a
bki.sgml 36.9 KB