• Tom Lane's avatar
    Test, don't just Assert, that mergejoin's inputs are in order. · d13a838e
    Tom Lane authored
    There are two Asserts in nodeMergejoin.c that are reachable if
    the input data is not in the expected order.  This seems way too
    fragile.  Alexander Lakhin reported a case where the assertions
    could be triggered with misconfigured foreign-table partitions,
    and bitter experience with unstable operating system collation
    definitions suggests another easy route to hitting them.  Neither
    Assert is in a place where we can't afford one more test-and-branch,
    so replace 'em with plain test-and-elog logic.
    
    Per bug #17395.  While the reported symptom is relatively recent,
    collation changes could happen anytime, so back-patch to all
    supported branches.
    
    Discussion: https://postgr.es/m/17395-8c326292078d1a57@postgresql.org
    d13a838e
nodeMergejoin.c 48.7 KB