• Thomas Munro's avatar
    Add WL_EXIT_ON_PM_DEATH pseudo-event. · cfdf4dc4
    Thomas Munro authored
    Users of the WaitEventSet and WaitLatch() APIs can now choose between
    asking for WL_POSTMASTER_DEATH and then handling it explicitly, or asking
    for WL_EXIT_ON_PM_DEATH to trigger immediate exit on postmaster death.
    This reduces code duplication, since almost all callers want the latter.
    
    Repair all code that was previously ignoring postmaster death completely,
    or requesting the event but ignoring it, or requesting the event but then
    doing an unconditional PostmasterIsAlive() call every time through its
    event loop (which is an expensive syscall on platforms for which we don't
    have USE_POSTMASTER_DEATH_SIGNAL support).
    
    Assert that callers of WaitLatchXXX() under the postmaster remember to
    ask for either WL_POSTMASTER_DEATH or WL_EXIT_ON_PM_DEATH, to prevent
    future bugs.
    
    The only process that doesn't handle postmaster death is syslogger.  It
    waits until all backends holding the write end of the syslog pipe
    (including the postmaster) have closed it by exiting, to be sure to
    capture any parting messages.  By using the WaitEventSet API directly
    it avoids the new assertion, and as a by-product it may be slightly
    more efficient on platforms that have epoll().
    
    Author: Thomas Munro
    Reviewed-by: Kyotaro Horiguchi, Heikki Linnakangas, Tom Lane
    Discussion: https://postgr.es/m/CAEepm%3D1TCviRykkUb69ppWLr_V697rzd1j3eZsRMmbXvETfqbQ%40mail.gmail.com,
                https://postgr.es/m/CAEepm=2LqHzizbe7muD7-2yHUbTOoF7Q+qkSD5Q41kuhttRTwA@mail.gmail.com
    cfdf4dc4
parallel.c 47.6 KB