• Andres Freund's avatar
    Use slots more widely in tuple mapping code and make naming more consistent. · cc2905e9
    Andres Freund authored
    It's inefficient to use a single slot for mapping between tuple
    descriptors for multiple tuples, as previously done when using
    ConvertPartitionTupleSlot(), as that means the slot's tuple descriptors
    change for every tuple.
    
    Previously we also, via ConvertPartitionTupleSlot(), built new tuples
    after the mapping even in cases where we, immediately afterwards,
    access individual columns again.
    
    Refactor the code so one slot, on demand, is used for each
    partition. That avoids having to change the descriptor (and allows to
    use the more efficient "fixed" tuple slots). Then use slot->slot
    mapping, to avoid unnecessarily forming a tuple.
    
    As the naming between the tuple and slot mapping functions wasn't
    consistent, rename them to execute_attr_map_{tuple,slot}.  It's likely
    that we'll also rename convert_tuples_by_* to denote that these
    functions "only" build a map, but that's left for later.
    
    Author: Amit Khandekar and Amit Langote, editorialized by me
    Reviewed-By: Amit Langote, Amit Khandekar, Andres Freund
    Discussion:
        https://postgr.es/m/CAJ3gD9fR0wRNeAE8VqffNTyONS_UfFPRpqxhnD9Q42vZB+Jvpg@mail.gmail.com
        https://postgr.es/m/e4f9d743-cd4b-efb0-7574-da21d86a7f36%40lab.ntt.co.jp
    Backpatch: -
    cc2905e9
execMain.c 99.1 KB