• Tom Lane's avatar
    Fix oversight in original coding of inline_function(): since · cc0cac4a
    Tom Lane authored
    check_sql_fn_retval allows binary-compatibility cases, the expression
    extracted from an inline-able SQL function might have a type that is only
    binary-compatible with the declared function result type.  To avoid possibly
    changing the semantics of the expression, we should insert a RelabelType node
    in such cases.  This has only been shown to have bad consequences in recent
    8.1 and up releases, but I suspect there may be failure cases in the older
    branches too, so patch it all the way back.  Per bug #3116 from Greg Mullane.
    
    Along the way, fix an omission in eval_const_expressions_mutator: it failed
    to copy the relabelformat field when processing a RelabelType.  No known
    observable failures from this, but it definitely isn't intended behavior.
    cc0cac4a
clauses.c 122 KB