• Tom Lane's avatar
    Use AF_UNSPEC not PF_UNSPEC in getaddrinfo calls. · cad4fe64
    Tom Lane authored
    According to the Single Unix Spec and assorted man pages, you're supposed
    to use the constants named AF_xxx when setting ai_family for a getaddrinfo
    call.  In a few places we were using PF_xxx instead.  Use of PF_xxx
    appears to be an ancient BSD convention that was not adopted by later
    standardization.  On BSD and most later Unixen, it doesn't matter much
    because those constants have equivalent values anyway; but nonetheless
    this code is not per spec.
    
    In the same vein, replace PF_INET by AF_INET in one socket() call, which
    wasn't even consistent with the other socket() call in the same function
    let alone the remainder of our code.
    
    Per investigation of a Cygwin trouble report from Marco Atzeri.  It's
    probably a long shot that this will fix his issue, but it's wrong in
    any case.
    cad4fe64
hba.c 58.4 KB