• Tom Lane's avatar
    Avoid pre-determining index names during CREATE TABLE LIKE parsing. · c92be3c0
    Tom Lane authored
    Formerly, when trying to copy both indexes and comments, CREATE TABLE LIKE
    had to pre-assign names to indexes that had comments, because it made up an
    explicit CommentStmt command to apply the comment and so it had to know the
    name for the index.  This creates bad interactions with other indexes, as
    shown in bug #6734 from Daniele Varrazzo: the preassignment logic couldn't
    take any other indexes into account so it could choose a conflicting name.
    
    To fix, add a field to IndexStmt that allows it to carry a comment to be
    assigned to the new index.  (This isn't a user-exposed feature of CREATE
    INDEX, only an internal option.)  Now we don't need preassignment of index
    names in any situation.
    
    I also took the opportunity to refactor DefineIndex to accept the IndexStmt
    as such, rather than passing all its fields individually in a mile-long
    parameter list.
    
    Back-patch to 9.2, but no further, because it seems too dangerous to change
    IndexStmt or DefineIndex's API in released branches.  The bug exists back
    to 9.0 where CREATE TABLE LIKE grew the ability to copy comments, but given
    the lack of prior complaints we'll just let it go unfixed before 9.2.
    c92be3c0
equalfuncs.c 67 KB