• Tom Lane's avatar
    Move rolenames test out of the core regression tests. · c91504b9
    Tom Lane authored
    This test script is unsafe to run in "make installcheck" mode for
    (at least) two reasons: it creates and destroys some role names
    that don't follow the "regress_xxx" naming convention, and it
    sets and then resets the application_name GUC attached to every
    existing role.  While we've not had complaints, these surely are
    not good things to do within a production installation, and
    regress.sgml pretty clearly implies that we won't do them.
    
    Rather than lose test coverage altogether, let's just move this
    script somewhere where it will get run by "make check" but not
    "make installcheck".  src/test/modules/ already has that property.
    
    Since it seems likely that we'll want other regression tests in
    future that also exceed the constraints of "make installcheck",
    create a generically-named src/test/modules/unsafe_tests/
    directory to hold them.
    
    Discussion: https://postgr.es/m/16638.1468620817@sss.pgh.pa.us
    c91504b9
rolenames.sql 18.9 KB