• Tom Lane's avatar
    Second try at fixing warnings caused by commit 9b43d73b. · c90b85e4
    Tom Lane authored
    Commit ef3f9e64 suppressed one cause of warnings here, but
    recent clang on OS X is still unhappy because we're passing a "long"
    to abs().  The fact that tm_gmtoff is declared as long is no doubt a
    hangover from days when int might be only 16 bits; but Postgres has
    never been able to run on such machines, so we can just cast it to int
    with no worries.  For consistency, also cast to int in the other
    uses of tm_gmtoff in this stanza.
    
    Note: this code is still broken on machines that don't follow C99
    integer-division-truncates-towards-zero rules.  Given the lack of
    complaints about it, I don't feel a large desire to complicate things
    enough to cope with the pre-C99 rules.
    c90b85e4
formatting.c 132 KB