• Tom Lane's avatar
    Fix PL/Tcl's encoding conversion logic. · c8c7c93d
    Tom Lane authored
    PL/Tcl appears to contain logic to convert strings between the database
    encoding and UTF8, which is the only encoding modern Tcl will deal with.
    However, that code has been disabled since commit 03489512, which
    made it "#if defined(UNICODE_CONVERSION)" and neglected to provide any way
    for that symbol to become defined.  That might have been all right back
    in 2001, but these days we take a dim view of allowing strings with
    incorrect encoding into the database.
    
    Remove the conditional compilation, fix warnings about signed/unsigned char
    conversions, clean up assorted places that didn't bother with conversions.
    (Notably, there were lots of assumptions that database table and field
    names didn't need conversion...)
    
    Add a regression test based on plpython_unicode.  It's not terribly
    thorough, but better than no test at all.
    c8c7c93d
pltcl_unicode.out 1.15 KB