• Tom Lane's avatar
    Fix two violations of the ResourceOwnerEnlarge/Remember protocol. · c5269472
    Tom Lane authored
    The point of having separate ResourceOwnerEnlargeFoo and
    ResourceOwnerRememberFoo functions is so that resource allocation
    can happen in between.  Doing it in some other order is just wrong.
    
    OpenTemporaryFile() did open(), enlarge, remember, which would leak the
    open file if the enlarge step ran out of memory.  Because fd.c has its own
    layer of resource-remembering, the consequences look like they'd be limited
    to an intratransaction FD leak, but it's still not good.
    
    IncrBufferRefCount() did enlarge, remember, incr-refcount, which would blow
    up if the incr-refcount step ever failed.  It was safe enough when written,
    but since the introduction of PrivateRefCountHash, I think the assumption
    that no error could happen there is pretty shaky.
    
    The odds of real problems from either bug are probably small, but still,
    back-patch to supported branches.
    
    Thomas Munro and Tom Lane, per a comment from Andres Freund
    c5269472
bufmgr.c 124 KB