• Tom Lane's avatar
    Fix s_lock.h PPC assembly code to be compatible with native AIX assembler. · c41a1215
    Tom Lane authored
    On recent AIX it's necessary to configure gcc to use the native assembler
    (because the GNU assembler hasn't been updated to handle AIX 6+).  This
    caused PG builds to fail with assembler syntax errors, because we'd try
    to compile s_lock.h's gcc asm fragment for PPC, and that assembly code
    relied on GNU-style local labels.  We can't substitute normal labels
    because it would fail in any file containing more than one inlined use of
    tas().  Fortunately, that code is stable enough, and the PPC ISA is simple
    enough, that it doesn't seem like too much of a maintenance burden to just
    hand-code the branch offsets, removing the need for any labels.
    
    Note that the AIX assembler only accepts "$" for the location counter
    pseudo-symbol.  The usual GNU convention is "."; but it appears that all
    versions of gas for PPC also accept "$", so in theory this patch will not
    break any other PPC platforms.
    
    This has been reported by a few people, but Steve Underwood gets the credit
    for being the first to pursue the problem far enough to understand why it
    was failing.  Thanks also to Noah Misch for additional testing.
    c41a1215
s_lock.h 27.3 KB