• Tom Lane's avatar
    Mop up some no-longer-necessary hacks around printf %.*s format. · c410af09
    Tom Lane authored
    Commit 54cd4f04 added some kluges to work around an old glibc bug,
    namely that %.*s could misbehave if glibc thought any characters in
    the supplied string were incorrectly encoded.  Now that we use our
    own snprintf.c implementation, we need not worry about that bug (even
    if it still exists in the wild).  Revert a couple of particularly
    ugly hacks, and remove or improve assorted comments.
    
    Note that there can still be encoding-related hazards here: blindly
    clipping at a fixed length risks producing wrongly-encoded output
    if the clip splits a multibyte character.  However, code that's
    doing correct multibyte-aware clipping doesn't really need a comment
    about that, while code that isn't needs an explanation why not,
    rather than a red-herring comment about an obsolete bug.
    
    Discussion: https://postgr.es/m/279428.1593373684@sss.pgh.pa.us
    c410af09
copy.c 147 KB