• Heikki Linnakangas's avatar
    Don't include file type bits in tar archive's mode field. · c0f279c4
    Heikki Linnakangas authored
    The "file mode" bits in the tar file header is not supposed to include the
    file type bits, e.g. S_IFREG or S_IFDIR. The file type is stored in a
    separate field. This isn't a problem in practice, all tar programs ignore
    the extra bits, but let's be tidy.
    
    This came up in a discussion around bug #11949, reported by Hendrik Grewe,
    although this doesn't fix the issue with tar --append. That turned out to be
    a bug in GNU tar. Schilly's tartest program revealed this defect in the tar
    created by pg_basebackup.
    
    This problem goes as far as we we've had pg_basebackup, but since this
    hasn't caused any problems in practice, let's be conservative and fix in
    master only.
    c0f279c4
tar.c 3.52 KB