• Peter Geoghegan's avatar
    Demote pg_unreachable() in heapam to an assertion. · bd9f4cf0
    Peter Geoghegan authored
    Commit d168b666, which overhauled index deletion, added a
    pg_unreachable() to the end of a sort comparator used when sorting heap
    TIDs from an index page.  This allows the compiler to apply
    optimizations that assume that the heap TIDs from the index AM must
    always be unique.
    
    That doesn't seem like a good idea now, given recent reports of
    corruption involving duplicate TIDs in indexes on Postgres 14.  Demote
    to an assertion, just in case.
    
    Backpatch: 14-, where index deletion was overhauled.
    bd9f4cf0
heapam.c 298 KB