• Tom Lane's avatar
    Fix performance issue in EXPLAIN (ANALYZE, TIMING OFF). · bcc6c4c2
    Tom Lane authored
    Commit af7914c6, which added the TIMING
    option to EXPLAIN, had an oversight: if the TIMING option is disabled
    then control in InstrStartNode() goes through an elog(DEBUG2) call, which
    typically does nothing but takes a noticeable amount of time to do it.
    Tweak the logic to avoid that.
    
    In HEAD, also change the elog(DEBUG2)'s in instrument.c to elog(ERROR).
    It's not very clear why they weren't like that to begin with, but this
    episode shows that not complaining more vociferously about misuse is
    likely to do little except allow bugs to remain hidden.
    
    While at it, adjust some code that was making possibly-dangerous
    assumptions about flag bits being in the rightmost byte of the
    instrument_options word.
    
    Problem reported by Pavel Stehule (via Tomas Vondra).
    bcc6c4c2
instrument.c 4.1 KB