• Robert Haas's avatar
    Don't allow system columns in CHECK constraints, except tableoid. · ba3d39c9
    Robert Haas authored
    Previously, arbitray system columns could be mentioned in table
    constraints, but they were not correctly checked at runtime, because
    the values weren't actually set correctly in the tuple.  Since it
    seems easy enough to initialize the table OID properly, do that,
    and continue allowing that column, but disallow the rest unless and
    until someone figures out a way to make them work properly.
    
    No back-patch, because this doesn't seem important enough to take the
    risk of destabilizing the back branches.  In fact, this will pose a
    dump-and-reload hazard for those upgrading from previous versions:
    constraints that were accepted before but were not correctly enforced
    will now either be enforced correctly or not accepted at all.  Either
    could result in restore failures, but in practice I think very few
    users will notice the difference, since the use case is pretty
    marginal anyway and few users will be relying on features that have
    not historically worked.
    
    Amit Kapila, reviewed by Rushabh Lathia, with doc changes by me.
    ba3d39c9
copy.c 117 KB