• Peter Geoghegan's avatar
    nbtree: Remove useless local variables. · b897b3aa
    Peter Geoghegan authored
    Copying block and offset numbers to local variables in _bt_insertonpg()
    made the code less readable.  Remove the variables.  There is already
    code that conditionally calls BufferGetBlockNumber() in the same block,
    so consistently do it that way instead.
    
    Calling BufferGetBlockNumber() is very cheap, but we might as well avoid
    it when it isn't truly necessary.  It isn't truly necessary for
    _bt_insertonpg() to call BufferGetBlockNumber() in almost all cases.
    
    Spotted while working on a patch that refactors the fastpath rightmost
    leaf page cache optimization, which was added by commit 2b272734.
    b897b3aa
nbtinsert.c 86.3 KB