• Michael Paquier's avatar
    Add result size as argument of pg_cryptohash_final() for overflow checks · b83dcf79
    Michael Paquier authored
    With its current design, a careless use of pg_cryptohash_final() could
    would result in an out-of-bound write in memory as the size of the
    destination buffer to store the result digest is not known to the
    cryptohash internals, without the caller knowing about that.  This
    commit adds a new argument to pg_cryptohash_final() to allow such sanity
    checks, and implements such defenses.
    
    The internals of SCRAM for HMAC could be tightened a bit more, but as
    everything is based on SCRAM_KEY_LEN with uses particular to this code
    there is no need to complicate its interface more than necessary, and
    this comes back to the refactoring of HMAC in core.  Except that, this
    minimizes the uses of the existing DIGEST_LENGTH variables, relying
    instead on sizeof() for the result sizes.  In ossp-uuid, this also makes
    the code more defensive, as it already relied on dce_uuid_t being at
    least the size of a MD5 digest.
    
    This is in philosophy similar to cfc40d38 for base64.c and aef8948f for
    hex.c.
    
    Reported-by: Ranier Vilela
    Author: Michael Paquier, Ranier Vilela
    Reviewed-by: Kyotaro Horiguchi
    Discussion: https://postgr.es/m/CAEudQAoqEGmcff3J4sTSV-R_16Monuz-UpJFbf_dnVH=APr02Q@mail.gmail.com
    b83dcf79
cryptohash.h 1.13 KB