• Tom Lane's avatar
    In psql, restore old behavior of Query_for_list_of_functions. · b6e132dd
    Tom Lane authored
    Historically, tab completion for functions has offered the names of
    aggregates as well.  This is essential in at least one context, namely
    GRANT/REVOKE, because there is no GRANT ON AGGREGATE syntax.  There
    are other cases where a command that nominally is for functions will
    allow aggregates as well, though not all do.
    
    Commit fd1a421f changed this query to disallow aggregates, but that
    doesn't seem to have been thought through very carefully.  Change it
    to allow aggregates (but still ignore procedures).
    
    We might at some point tighten this up, but it'd require sorting through
    all the uses of this query to see which ones should offer aggregate
    names and which shouldn't.  Given the lack of field complaints about
    the historical laxity here, that's work I'm not eager to do right now.
    
    Discussion: https://postgr.es/m/14268.1520283126@sss.pgh.pa.us
    b6e132dd
tab-complete.c 162 KB