• Michael Paquier's avatar
    Refactor MD5 implementations according to new cryptohash infrastructure · b67b57a9
    Michael Paquier authored
    This commit heavily reorganizes the MD5 implementations that exist in
    the tree in various aspects.
    
    First, MD5 is added to the list of options available in cryptohash.c and
    cryptohash_openssl.c.  This means that if building with OpenSSL, EVP is
    used for MD5 instead of the fallback implementation that Postgres had
    for ages.  With the recent refactoring work for cryptohash functions,
    this change is straight-forward.  If not building with OpenSSL, a
    fallback implementation internal to src/common/ is used.
    
    Second, this reduces the number of MD5 implementations present in the
    tree from two to one, by moving the KAME implementation from pgcrypto to
    src/common/, and by removing the implementation that existed in
    src/common/.  KAME was already structured with an init/update/final set
    of routines by pgcrypto (see original pgcrypto/md5.h) for compatibility
    with OpenSSL, so moving it to src/common/ has proved to be a
    straight-forward move, requiring no actual manipulation of the internals
    of each routine.  Some benchmarking has not shown any performance gap
    between both implementations.
    
    Similarly to the fallback implementation used for SHA2, the fallback
    implementation of MD5 is moved to src/common/md5.c with an internal
    header called md5_int.h for the init, update and final routines.  This
    gets then consumed by cryptohash.c.
    
    The original routines used for MD5-hashed passwords are moved to a
    separate file called md5_common.c, also in src/common/, aimed at being
    shared between all MD5 implementations as utility routines to keep
    compatibility with any code relying on them.
    
    Like the SHA2 changes, this commit had its round of tests on both Linux
    and Windows, across all versions of OpenSSL supported on HEAD, with and
    even without OpenSSL.
    
    Author: Michael Paquier
    Reviewed-by: Daniel Gustafsson
    Discussion: https://postgr.es/m/20201106073434.GA4961@paquier.xyz
    b67b57a9
cryptohash.h 1.14 KB