• Tom Lane's avatar
    Tighten coding for non-composite case in plperl's return_next. · b4cc35fb
    Tom Lane authored
    Coverity complained about this code's practice of using scalar variables
    as single-element arrays.  While that's really just nitpicking, it probably
    is more readable to declare them as arrays, so let's do that.  A more
    important point is that the code was just blithely assuming that the
    result tupledesc has exactly one column; if it doesn't, we'd likely get
    a crash of some sort in tuplestore_putvalues.  Since the tupledesc is
    manufactured outside of plperl, that seems like an uncomfortably long
    chain of assumptions.  We can nail it down at little cost with a sanity
    check earlier in the function.
    b4cc35fb
plperl.c 107 KB