• Tom Lane's avatar
    Fix misparsing of empty value in conninfo_uri_parse_params(). · b26e2081
    Tom Lane authored
    After finding an "=" character, the pointer was advanced twice when it
    should only advance once.  This is harmless as long as the value after "="
    has at least one character; but if it doesn't, we'd miss the terminator
    character and include too much in the value.
    
    In principle this could lead to reading off the end of memory.  It does not
    seem worth treating as a security issue though, because it would happen on
    client side, and besides client logic that's taking conninfo strings from
    untrusted sources has much worse security problems than this.
    
    Report and patch received off-list from Thomas Fanghaenel.
    Back-patch to 9.2 where the faulty code was introduced.
    b26e2081
fe-connect.c 143 KB