• Tom Lane's avatar
    Fix pg_dump --inserts mode for generated columns with dropped columns. · aedc4600
    Tom Lane authored
    If a table contains a generated column that's preceded by a dropped
    column, dumpTableData_insert failed to account for the dropped
    column, and would emit DEFAULT placeholder(s) in the wrong column(s).
    This resulted in failures at restore time.  The default COPY code path
    did not have this bug, likely explaining why it wasn't noticed sooner.
    
    While we're fixing this, we can be a little smarter about the
    situation: (1) avoid unnecessarily fetching the values of generated
    columns, (2) omit generated columns from the output, too, if we're
    using --column-inserts.  While these modes aren't expected to be
    as high-performance as the COPY path, we might as well be as
    efficient as we can; it doesn't add much complexity.
    
    Per report from Дмитрий Иванов.
    Back-patch to v12 where generated columns came in.
    
    Discussion: https://postgr.es/m/CAPL5KHrkBniyQt5e1rafm5DdXvbgiiqfEQEJ9GjtVzN71Jj5pA@mail.gmail.com
    aedc4600
pg_dump.c 573 KB