• Tom Lane's avatar
    Mostly-cosmetic adjustments of TOAST-related macros. · aeb1631e
    Tom Lane authored
    The authors of bbe0a81d hadn't quite got the idea that macros named
    like SOMETHING_4B_C were only meant for internal endianness-related
    details in postgres.h.  Choose more legible names for macros that are
    intended to be used elsewhere.  Rearrange postgres.h a bit to clarify
    the separation between those internal macros and ones intended for
    wider use.
    
    Also, avoid using the term "rawsize" for true decompressed size;
    we've used "extsize" for that, because "rawsize" generally denotes
    total Datum size including header.  This choice seemed particularly
    unfortunate in tests that were comparing one of these meanings to
    the other.
    
    This patch includes a couple of not-purely-cosmetic changes: be
    sure that the shifts aligning compression methods are unsigned
    (not critical today, but will be when compression method 2 exists),
    and fix broken definition of VARATT_EXTERNAL_GET_COMPRESSION (now
    VARATT_EXTERNAL_GET_COMPRESS_METHOD), whose callers worked only
    accidentally.
    
    Discussion: https://postgr.es/m/574197.1616428079@sss.pgh.pa.us
    aeb1631e
postgres.h 23.6 KB