• Peter Geoghegan's avatar
    Sanitize line pointers within contrib/amcheck. · a9ce839a
    Peter Geoghegan authored
    Adopt a more defensive approach to accessing index tuples in
    contrib/amcheck: verify that each line pointer looks sane before
    accessing associated tuple using pointer arithmetic based on line
    pointer's offset.  This avoids undefined behavior and assertion failures
    in cases where line pointers are corrupt.
    
    Issue spotted following a complaint about an assertion failure by
    Grigory Smolkin, which involved a test harness that deliberately
    corrupts indexes.
    
    This is arguably a bugfix, but no backpatch given the lack of field
    reports beyond Grigory's.
    
    Discussion: https://postgr.es/m/CAH2-WzmkurhCqnyLHxk0VkOZqd49+ZZsp1xAJOg7j2x7dmp_XQ@mail.gmail.com
    a9ce839a
verify_nbtree.c 95.4 KB