• Tom Lane's avatar
    Reject "23:59:60.nnn" in datetime input. · a9632830
    Tom Lane authored
    It's intentional that we don't allow values greater than 24 hours,
    while we do allow "24:00:00" as well as "23:59:60" as inputs.
    However, the range check was miscoded in such a way that it would
    accept "23:59:60.nnn" with a nonzero fraction.  For time or timetz,
    the stored result would then be greater than "24:00:00" which would
    fail dump/reload, not to mention possibly confusing other operations.
    
    Fix by explicitly calculating the result and making sure it does not
    exceed 24 hours.  (This calculation is redundant with what will happen
    later in tm2time or tm2timetz.  Maybe someday somebody will find that
    annoying enough to justify refactoring to avoid the duplication; but
    that seems too invasive for a back-patched bug fix, and the cost is
    probably unmeasurable anyway.)
    
    Note that this change also rejects such input as the time portion
    of a timestamp(tz) value.
    
    Back-patch to v10.  The bug is far older, but to change this pre-v10
    we'd need to ensure that the logic behaves sanely with float timestamps,
    which is possibly nontrivial due to roundoff considerations.
    Doesn't really seem worth troubling with.
    
    Per report from Christoph Berg.
    
    Discussion: https://postgr.es/m/20200520125807.GB296739@msg.df7cb.de
    a9632830
time.sql 1.62 KB