• Tomas Vondra's avatar
    Refactor geometric functions and operators · a7dc63d9
    Tomas Vondra authored
    The primary goal of this patch is to eliminate duplicate code and share
    code between different geometric data types more often, to prepare the
    ground for additional patches.  Until now the code reuse was limited,
    probably because the simpler types (line and point) were implemented
    after the more complex ones.
    
    The changes are quite extensive and can be summarised as:
    
    * Eliminate SQL-level function calls.
    * Re-use more functions to implement others.
    * Unify internal function names and signatures.
    * Remove private functions from geo_decls.h.
    * Replace should-not-happen checks with assertions.
    * Add comments describe for various functions.
    * Remove some unreachable code.
    * Define delimiter symbols of line datatype like the other ones.
    * Remove the GEODEBUG macro and printf() calls.
    * Unify code style of a few oddly formatted lines.
    
    While the goal was to cause minimal user-visible changes, it was not
    possible to keep the original behavior in all cases - for example when
    handling NaN values, or when reusing code makes the functions return
    consistent results.
    
    Author: Emre Hasegeli
    Reviewed-by: Kyotaro Horiguchi, me
    
    Discussion: https://www.postgresql.org/message-id/CAE2gYzxF7-5djV6-cEvqQu-fNsnt%3DEqbOURx7ZDg%2BVv6ZMTWbg%40mail.gmail.com
    a7dc63d9
geo_spgist.c 20.5 KB