• Bruce Momjian's avatar
    · a79b698a
    Bruce Momjian authored
    Here's a version of my suggested diffs transplanted to 7.1 beta 5.  I'm
    still looking at the best way to integrate Tom Vijlbrief's fixes
    (insofar as they're still needed); would 7.2 be a suitable time for
    incompatible API changes?
    
    
    Jeroen
    
    
    Changes:
    
    (*) Introduced bool, true, false (replacing some int, 1, 0)
    (*) Made some member functions const
    (*) Documented GetIsNull()
    (*) Marked DisplayTuples() and PrintTuples() as obsolescent; fixed possible
        portability problem (assumed that NULL pointer equals all-zero bit pattern)
    (*) PrintTuples(): renamed width parameter to fillAlign to conform with other
        usage; fixed memory leak and compile issue w.r.t. field separator (should
        also slightly improve performance)
    (*) Fixed some minor compilation issues
    (*) Moved "using namespace std;" out of headers, where they didn't belong; used
        new (temporary) preprocessor macro PGSTD to do this
    (*) Made ToString() static, removed unneeded memset(), made buffer size adapt
        to sizeof(int)
    (*) Made some constructors explicit
    (*) Changed some const std::string & parameters to plain std::string
    (*) Marked PgCursor::Cursor(std::string) as obsolescent (setter with same name
        as getter--bad style)
    (*) Renamed some paramaters previously named "string"
    (*) Introduced size_type typedef for number of tuples in result set
    (*) PgTransaction now supports re-opening after closing, and aborts if not
        explicitly committed prior to destruction
    
    J. T. Vermeulen
    a79b698a
pgconnection.h 2.76 KB