• Tom Lane's avatar
    As noted by Andrew Gierth, there's really no need any more to force a junk · a77eaa6a
    Tom Lane authored
    filter to be used when INSERT or SELECT INTO has a plan that returns raw
    disk tuples.  The virtual-tuple-slot optimizations that were put in place
    awhile ago mean that ExecInsert has to do ExecMaterializeSlot, and that
    already copies the tuple if it's raw (and does so more efficiently than
    a junk filter, too).  So get rid of that logic.  This in turn means that
    we can throw away ExecMayReturnRawTuples, which wasn't used for any other
    purpose, and was always a kluge anyway.
    
    In passing, move a couple of SELECT-INTO-specific fields out of EState
    and into the private state of the SELECT INTO DestReceiver, as was foreseen
    in an old comment there.  Also make intorel_receive use ExecMaterializeSlot
    not ExecCopySlotTuple, for consistency with ExecInsert and to possibly save
    a tuple copy step in some cases.
    a77eaa6a
execMain.c 76.5 KB