• Alvaro Herrera's avatar
    Fix crasher bug in array_position(s) · a73491e5
    Alvaro Herrera authored
    array_position and its cousin array_positions were caching the element
    type equality function's FmgrInfo without being careful enough to put it
    in a long-lived context.  This is obviously broken but it didn't matter
    in most cases; only when using arrays of records (involving record_eq)
    it becomes a problem.  The fix is to ensure that the type's equality
    function's FmgrInfo is cached in the array_position's flinfo->fn_mcxt
    rather than the current memory context.
    
    Apart from record types, the only other case that seems complex enough
    to possibly cause the same problem are range types.  I didn't find a way
    to reproduce the problem with those, so I only include the test case
    submitted with the bug report as regression test.
    
    Bug report and patch: Junseok Yang
    Discussion: https://postgr.es/m/CAE+byMupUURYiZ6bKYgMZb9pgV1CYAijJGqWj-90W=nS7uEOeA@mail.gmail.com
    Backpatch to 9.5, where array_position appeared.
    a73491e5
arrays.out 89.6 KB