• Heikki Linnakangas's avatar
    Replace SYSTEMQUOTEs with Windows-specific wrapper functions. · a692ee58
    Heikki Linnakangas authored
    It's easy to forget using SYSTEMQUOTEs when constructing command strings
    for system() or popen(). Even if we fix all the places missing it now, it is
    bound to be forgotten again in the future. Introduce wrapper functions that
    do the the extra quoting for you, and get rid of SYSTEMQUOTEs in all the
    callers.
    
    We previosly used SYSTEMQUOTEs in all the hard-coded command strings, and
    this doesn't change the behavior of those. But user-supplied commands, like
    archive_command, restore_command, COPY TO/FROM PROGRAM calls, as well as
    pgbench's \shell, will now gain an extra pair of quotes. That is desirable,
    but if you have existing scripts or config files that include an extra
    pair of quotes, those might need to be adjusted.
    
    Reviewed by Amit Kapila and Tom Lane
    a692ee58
configure.in 62.8 KB