• Tom Lane's avatar
    Sync guc.c and postgresql.conf.sample with the SGML docs. · a55a9847
    Tom Lane authored
    It seems that various people have moved GUCs around in the config.sgml
    listing without bothering to make the code agree.  Ensure that the
    config_group codes assigned to GUCs match where they are listed in
    config.sgml.  Likewise ensure that postgresql.conf.sample lists GUCs
    in the same sub-section and same ordering as they appear in config.sgml.
    
    (I've got some doubts about some of these choices, but for the purposes
    of this patch, we'll treat config.sgml as gospel.)
    
    Notably, this requires adding a WAL_RECOVERY config_group value,
    because 1d257577 didn't.  As long as we're renumbering that enum
    anyway, let's take out the values corresponding to major groups
    that are divided into sub-groups.  No GUC should be assigned to the
    major group itself, so those values just create a temptation to
    do the wrong thing, while adding work for translators.
    
    In passing, adjust the short_desc strings for PRESET_OPTIONS GUCs
    to uniformly use the phrasing "Shows XYZ.", removing the impression
    some of these strings left that you can set the value.
    
    While some of these errors are old, no back-patch, as changing the
    contents of the pg_settings view in stable branches seems more likely
    to be seen as a compatibility break than anything helpful.
    
    Bharath Rupireddy, Justin Pryzby, Tom Lane
    
    Discussion: https://postgr.es/m/16997-ff16127f6e0d1390@postgresql.org
    Discussion: https://postgr.es/m/20210413123139.GE6091@telsasoft.com
    a55a9847
guc.c 325 KB