• Tom Lane's avatar
    Avoid believing incomplete MCV-only stats in get_variable_range(). · a54509bf
    Tom Lane authored
    get_variable_range() would incautiously believe that statistics
    containing only an MCV list are sufficient to derive a range estimate.
    That's okay for an enum-like column that contains only MCVs, but
    otherwise the estimate could be pretty bad.  Make it report that the
    range is indeterminate unless the MCVs plus nullfrac account for
    the whole table.
    
    I don't think this needs a dedicated test case, since a quick code
    coverage check verifies that the existing regression tests traverse
    all the alternatives.  There is room to doubt that a future-proof
    test case could be built anyway, given that the submitted example
    accidentally doesn't fail before v11.
    
    Per bug #17207 from Simon Perepelitsa.  Back-patch to v10.
    In principle this has been broken all along, but I'm hesitant to
    make such changes in 9.6, since if anyone is unhappy with 9.6.24's
    behavior there will be no second chance to fix it.
    
    Discussion: https://postgr.es/m/17207-5265aefa79e333b4@postgresql.org
    a54509bf
selfuncs.c 238 KB