• Tom Lane's avatar
    Make contrib/unaccent's unaccent() function work when not in search path. · a5322ca1
    Tom Lane authored
    Since the fixes for CVE-2018-1058, we've advised people to schema-qualify
    function references in order to fix failures in code that executes under
    a minimal search_path setting.  However, that's insufficient to make the
    single-argument form of unaccent() work, because it looks up the "unaccent"
    text search dictionary using the search path.
    
    The most expedient answer seems to be to remove the search_path dependency
    by making it look in the same schema that the unaccent() function itself
    is declared in.  This will definitely work for the normal usage of this
    function with the unaccent dictionary provided by the extension.
    It's barely possible that there are people who were relying on the
    search-path-dependent behavior to select other dictionaries with the same
    name; but if there are any such people at all, they can still get that
    behavior by writing unaccent('unaccent', ...), or possibly
    unaccent('unaccent'::text::regdictionary, ...) if the lookup has to be
    postponed to runtime.
    
    Per complaint from Gunnlaugur Thor Briem.  Back-patch to all supported
    branches.
    
    Discussion: https://postgr.es/m/CAPs+M8LCex6d=DeneofdsoJVijaG59m9V0ggbb3pOH7hZO4+cQ@mail.gmail.com
    a5322ca1
unaccent.sgml 6.02 KB