• Tom Lane's avatar
    Prevent buffer overrun in read_tablespace_map(). · a50e4fd0
    Tom Lane authored
    Robert Foggia of Trustwave reported that read_tablespace_map()
    fails to prevent an overrun of its on-stack input buffer.
    Since the tablespace map file is presumed trustworthy, this does
    not seem like an interesting security vulnerability, but still
    we should fix it just in the name of robustness.
    
    While here, document that pg_basebackup's --tablespace-mapping option
    doesn't work with tar-format output, because it doesn't.  To make it
    work, we'd have to modify the tablespace_map file within the tarball
    sent by the server, which might be possible but I'm not volunteering.
    (Less-painful solutions would require changing the basebackup protocol
    so that the source server could adjust the map.  That's not very
    appetizing either.)
    a50e4fd0
xlog.c 401 KB