• Tom Lane's avatar
    Improve parser's and planner's handling of set-returning functions. · a4c35ea1
    Tom Lane authored
    Teach the parser to reject misplaced set-returning functions during parse
    analysis using p_expr_kind, in much the same way as we do for aggregates
    and window functions (cf commit eaccfded).  While this isn't complete
    (it misses nesting-based restrictions), it's much better than the previous
    error reporting for such cases, and it allows elimination of assorted
    ad-hoc expression_returns_set() error checks.  We could add nesting checks
    later if it seems important to catch all cases at parse time.
    
    There is one case the parser will now throw error for although previous
    versions allowed it, which is SRFs in the tlist of an UPDATE.  That never
    behaved sensibly (since it's ill-defined which generated row should be
    used to perform the update) and it's hard to see why it should not be
    treated as an error.  It's a release-note-worthy change though.
    
    Also, add a new Query field hasTargetSRFs reporting whether there are
    any SRFs in the targetlist (including GROUP BY/ORDER BY expressions).
    The parser can now set that basically for free during parse analysis,
    and we can use it in a number of places to avoid expression_returns_set
    searches.  (There will be more such checks soon.)  In some places, this
    allows decontorting the logic since it's no longer expensive to check for
    SRFs in the tlist --- so I made the checks parallel to the handling of
    hasAggs/hasWindowFuncs wherever it seemed appropriate.
    
    catversion bump because adding a Query field changes stored rules.
    
    Andres Freund and Tom Lane
    
    Discussion: <24639.1473782855@sss.pgh.pa.us>
    a4c35ea1
parse_func.h 2.27 KB