• Tom Lane's avatar
    Fix a thinko in join_is_legal: when we decide we can implement a semijoin · a43b190e
    Tom Lane authored
    by unique-ifying the RHS and then inner-joining to some other relation,
    that is not grounds for violating the RHS of some other outer join.
    Noticed while regression-testing new GEQO code, which will blindly follow
    any path that join_is_legal says is legal, and then complain later if that
    leads to a dead end.
    
    I'm not certain that this can result in any visible failure in 8.4: the
    mistake may always be masked by the fact that subsequent attempts to join
    the rest of the RHS of the other join will fail.  But I'm not certain it
    can't, either, and it's definitely not operating as intended.  So back-patch.
    
    The added regression test depends on the new no-failures-allowed logic
    that I'm about to commit in GEQO, so no point back-patching that.
    a43b190e
join.sql 12.8 KB