• Michael Paquier's avatar
    Fix corner case with 16kB-long decompression in pgcrypto, take 2 · a3ab7a70
    Michael Paquier authored
    A compressed stream may end with an empty packet.  In this case
    decompression finishes before reading the empty packet and the
    remaining stream packet causes a failure in reading the following
    data.  This commit makes sure to consume such extra data, avoiding a
    failure when decompression the data.  This corner case was reproducible
    easily with a data length of 16kB, and existed since e94dd6ab.  A cheap
    regression test is added to cover this case based on a random,
    incompressible string.
    
    The first attempt of this patch has allowed to find an older failure
    within the compression logic of pgcrypto, fixed by b9b61057.  This
    involved SLES 15 with z390 where a custom flavor of libz gets used.
    Bonus thanks to Mark Wong for providing access to the specific
    environment.
    
    Reported-by: Frank Gagnepain
    Author: Kyotaro Horiguchi, Michael Paquier
    Reviewed-by: Tom Lane
    Discussion: https://postgr.es/m/16476-692ef7b84e5fb893@postgresql.org
    Backpatch-through: 9.5
    a3ab7a70
pgp-compression.out 2.05 KB