• Tom Lane's avatar
    Initial code review for CustomScan patch. · a34fa8ee
    Tom Lane authored
    Get rid of the pernicious entanglement between planner and executor headers
    introduced by commit 0b03e595.
    
    Also, rearrange the CustomFoo struct/typedef definitions so that all the
    typedef names are seen as used by the compiler.  Without this pgindent
    will mess things up a bit, which is not so important perhaps, but it also
    removes a bizarre discrepancy between the declaration arrangement used for
    CustomExecMethods and that used for CustomScanMethods and
    CustomPathMethods.
    
    Clean up the commentary around ExecSupportsMarkRestore to reflect the
    rather large change in its API.
    
    Const-ify register_custom_path_provider's argument.  This necessitates
    casting away const in the function, but that seems better than forcing
    callers of the function to do so (or else not const-ify their method
    pointer structs, which was sort of the whole point).
    
    De-export fix_expr_common.  I don't like the exporting of fix_scan_expr
    or replace_nestloop_params either, but this one surely has got little
    excuse.
    a34fa8ee
execnodes.h 66.9 KB