• Tom Lane's avatar
    Remove useless pg_strdup() operations. · a2d75b67
    Tom Lane authored
    split_to_stringlist() doesn't modify its first argument nor expect it
    to remain valid after exit, so there's no need to duplicate the optarg
    string at the call sites.  Per Coverity.  (This has been wrong all along,
    but commit 052cc223 changed the useless calls from "strdup" to
    "pg_strdup", which apparently made Coverity think it's a new bug.
    It's not, but it's also not worth back-patching.)
    a2d75b67
pg_regress.c 62.3 KB