• Kevin Grittner's avatar
    Fix misplaced right paren bugs in pgstatfuncs.c. · a133bf70
    Kevin Grittner authored
    The bug would only show up if the C sockaddr structure contained
    zero in the first byte for a valid address; otherwise it would
    fail to fail, which is probably why it went unnoticed for so long.
    
    Patch submitted by Joel Jacobson after seeing an article by Andrey
    Karpov in which he reports finding this through static code
    analysis using PVS-Studio.  While I was at it I moved a definition
    of a local variable referenced in the buggy code to a more local
    context.
    
    Backpatch to all supported branches.
    a133bf70
pgstatfuncs.c 39.5 KB