• Tom Lane's avatar
    Sync patternsel_common's operator selection logic with pattern_prefix's. · 9ff5b699
    Tom Lane authored
    Make patternsel_common() select the comparison operators to use with
    hardwired logic that matches pattern_prefix()'s new logic, eliminating
    its dependencies on particular index opfamilies.
    
    This shouldn't change any behavior, as it's just replacing runtime
    operator lookups with the same values hard-wired.  But it makes these
    closely-related functions look more alike, and saving some runtime
    syscache lookups is worth something.
    
    Actually, it's not quite true that this is zero behavioral change:
    when estimating for a column of type "name", the comparison constant
    will be kept as "text" not coerced to "name".  But that's more correct
    anyway, and it allows additional simplification of the coercion logic,
    again syncing this more closely with pattern_prefix().
    
    Per consideration of a report from Manuel Rigger.
    
    Discussion: https://postgr.es/m/CA+u7OA7nnGYy8rY0vdTe811NuA+Frr9nbcBO9u2Z+JxqNaud+g@mail.gmail.com
    9ff5b699
like_support.c 48.6 KB